Re: [libvirt] [PATCH] node_device_udev: Try harder to get human readable vendor:product

On 09/09/2014 02:20 PM, Lubomir Rintel wrote:

The manufacurer and product from USB device itself are usually not particularly useful -- they tend to be missing, or ugly (all-uppercase, padded with spaces, etc.). Prefer what's in the usb id database and fall back to descriptors only if the device is too now to be in database.

s/now/new/

--- Before: http://v3.sk/~lkundrak/virt/old.png After: http://v3.sk/~lkundrak/virt/libvirt.png

src/node_device/node_device_udev.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)

ACK I have included the bug link in the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1138887 and pushed it. Congratulations on your first libvirt patch! Jan