Re: [PATCH 9/9] util: Avoid using wrong free function
On 6/16/20 8:16 AM, Daniel P. Berrangé wrote:
On Tue, Jun 16, 2020 at 08:07:10AM -0400, John Ferlan wrote:
> Since 1e2ae2e31, changes to use the automagic free logic didn't take
> into account that one path uses posix_memalign and the other uses
> VIR_ALLOC_N - the former requires using VIR_FREE() and not g_free()
> to free the memory.
VIR_FREE calls g_free, so they're semantically identical
Hmm... this one was something that had been on my list of false
positives (~60 patches) and wait for enough other changes before posting
list since March, but I see that reverting it doesn't cause the error
any more. So sure dropping is understandable...
Tks -
John