Re: [libvirt] [PATCH] Fix a reference leak for node devices.
2010/6/25 Laine Stump <laine(a)laine.org>:
On 06/25/2010 05:22 PM, Chris Lalancette wrote:
>
> There was one major, and a few minor bugs having to do with
> the reference counting of node devices in daemon/remote.c
> The major bug was that remoteDispatchNodeDeviceListCaps()
> was completely failing to unreference node devices; this
> would lead to many open file descriptors, which would eventually
> fail.
>
> The minor bugs were along the same lines, but were in rarely
> used error paths. Still, they should be corrected.
>
> Signed-off-by: Chris Lalancette<clalance(a)redhat.com>
> ---
ACK for the ones that are here. But what about the other NodeDevice
functions:
remoteDispatchNodeDeviceDettach
remoteDispatchNodeDeviceReAttach
remoteDispatchNodeDeviceReset
remoteDispatchNodeDeviceDestroy
Don't those need the same treatment?
Yes. I squashed in my additional ACKed patch for this, tweak the
commit message a bit to reflect this and pushed the result.
Matthias