Re: [libvirt] [PATCHv3 2/3] Add a name to virPortAllocator

On Wed, Nov 13, 2013 at 06:01:41PM +0100, Ján Tomko wrote:

This allows its error messages to be more specific. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 9 ++++++--- src/util/virportallocator.c | 9 +++++++-- src/util/virportallocator.h | 3 ++- tests/virportallocatortest.c | 4 ++-- 5 files changed, 19 insertions(+), 9 deletions(-)

You leak the *name. ACK if you add VIR_FREE(pa->name) into virPortAllocatorDispose(). Martin