Re: [libvirt] PATCH: Fix NULL checks in openvz driver
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote:
...
> All looks correct.
> However, I'm a little nervous about hard-coding those '[3]'s.
> What if someone inserts a new --foo option somewhere before
> the NULL place-holder, or otherwise rearranges the options?
> Then we'll have to remember to update that "3" below to e.g.,
"4".
> Easy to miss that...
I just realized there is a much simpler way todo this...
...
- const char *prog[] = {VZCTL, "--quiet",
"stop", vm->def->name, NULL};
+ const char *prog[] = {VZCTL, "--quiet", "stop", vm ?
vm->def->name : NULL, NULL};
Ahh... much better ;-)
ACK