Re: [libvirt] [PATCH] build: fix some mingw issues
On 06/03/2010 08:02 AM, Daniel P. Berrange wrote:
> So, is the libvirt patch worth installing, while we wait for the
> eventual fix of dependencies to not force mingw32-pthreads on 64-bit users?
How about changing configure.ac so that it defaults to looking for win32
threads on Win32, rather than trying pthreads
That would also be a useful patch, but seems like it would be
insufficient on its own. In other words, there are two issues here -
dealing with a broken <pthread.h> if it gets pulled in (which, for
example, it WILL be pulled in by gnulib if it exists since it defines
struct timespec, even if we don't use it for anything pthread-related),
and the issue of whether we should favor pthread or win32 threading.
I'll start working on a patch for the latter (favor win32 threading even
if mingw32-pthreads is installed), but that should not interfere with
installing this patch.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)