Re: [libvirt] Works: libvirt client on OS X 10.5.6

I will create a specific sub-dir and let you know.

>>> On Thu, May 07, 2009 at 11:50:25PM -0500, Schley Andrew Kutz wrote: >>>> - Set environment variables: >>>> >>>> export LDFLAGS="-L/opt/local/lib" >>>> export CPPFLAGS="-I/opt/local/include" >>>> export MACOSX_DEPLOYMENT_TARGET=10.4 >>>> src/virsh.c:5665

>>>> >>>> if (command_ret != 0 /* WEXITSTATUS (0) */) { > > That's bizarre ... > > WEXITSTATUS is defined in virsh.c: > > #ifndef WEXITSTATUS > # define WEXITSTATUS(x) ((x) & 0xff) > #endif > > it's used only once at the place you pointed out: > > if (command_ret != WEXITSTATUS (0)) { > > I think it was used for cygwin portability, but in that > case I would have expected > > if (WEXITSTATUS(command_ret) != 0) { > > Why did this break on OS-X ?

>>> That's great - we can easily fix these 2 bugs. >>> >>>> - Compile >>>> >>>> The MACOSX_DEPLOYMENT_TARGET variable is very important, otherwise >>>> you >>>> will get symbol errors when linking. > > What about detecting MACOSX_DEPLOYMENT_TARGET, because I assume it > will change from one environment to another, do this in configure.in > and > export is in all Makefiles.am ? There must be a way to export the env > variable from the generated Makefiles surely...