Re: [libvirt] [PATCH 0/2] Enable QEMU_CAPS_PCI_ROMBAR unconditionally
On Fri, May 13, 2016 at 03:47:57PM +0200, Andrea Bolognani wrote:
This capability was not handled correctly, causing aarch64
guests having
<interface type='network'>
...
<rom bar='off'/>
</interface>
to fail at startup with
error: unsupported configuration: rombar and romfile not
supported in this QEMU binary
I'm not sure whether we should drop the QEMU_CAPS_PCI_ROMBAR
capability entirely now that it's enabled unconditionally and
there is no code checking for it; as I understand it, we don't
ever drop capabilities, hence the current implementation.
We cannot drop capabilities, but you can rename that capability to
X_QEMU_CAPS_PCI_ROMBAR and don't even set that capability. Check the
src/qemu/qemu_capabilities.h, there is a lot of those X_* capabilities. Even
though you have already ACKs for this series, I would suggest to send a v2 and
use X_QEMU_CAPS_PCI_ROMBAR.
Pavel