On 3/14/24 14:42, Michal Prívozník wrote:
On 3/14/24 13:10, Pavel Hrdina wrote:
On Thu, Mar 14, 2024 at 10:34:28AM +0100, Michal Privoznik wrote:
As of commit [1] glibc may overwrite a call to open() with call to __open_2() (if only two arguments are provided and the code is compiled with clang). But since we are not mocking the latter our test suite is broken as tests try to access paths outside of our repo.
1: https://sourceware.org/git/?p=glibc.git;a=commit;h=86889e22db329abac618c6a41... Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- meson.build | 13 +++++++++++++ tests/nssmock.c | 26 +++++++++++++++++++++++++ tests/qemusecuritymock.c | 24 +++++++++++++++++++++++ tests/vircgroupmock.c | 42 ++++++++++++++++++++++++++++++++++++++++ tests/virfilewrapper.c | 18 +++++++++++++++++ tests/virmock.h | 4 ++++ tests/virpcimock.c | 17 ++++++---------- tests/virtestmock.c | 20 +++++++++++++++++++ tests/virusbmock.c | 22 +++++++++++++++++++++ 9 files changed, 175 insertions(+), 11 deletions(-)
Maybe we can switch all those WITH___OPEN_2 to WITH___OPEN_2_DECL? IOW - provide the mock only if conditions align just right for the declaration to exist. Let me see what our pipeline would think about that.
Nope, that's not gonna fly: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1213599078 Michal