Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries
On Wed, 2019-06-19 at 17:00 +0200, Christophe de Dinechin wrote:
> Andrea Bolognani (5):
> docs: Update jQuery
> docs: Update Moment.js
> docs: Update jquery.rss
> docs: Perform JavaScript minimization at build time
> spec: Require uglifyjs for RPM build
In the spec file, why do you BuildRequire uglify-js only on Fedora?
uglifyjs is not packaged for RHEL, which is the other platform our
spec file targets, so we can't really BuildRequire it there.
Does that mean that if you build elsewhere, you may end up with a
build that minifies or not depending on whether uglifyjs is in path or not?
Yeah. Luckily we're not going with these patches but with Martin's
approach instead, which neatly sidesteps this issue :)
--
Andrea Bolognani / Red Hat / Virtualization