Re: [PATCH 0/4] storage_backend_iscsi_direct: Refactor string list use and cleanup

On 6/18/21 3:04 PM, Peter Krempa wrote:

Peter Krempa (4): conf: storage: Introduce virStoragePoolSourceListFree virStorageBackendISCSIDirectFindPoolSources: Use allocated virStoragePoolSourceList virISCSIDirectUpdateTargets: Rework to simplify cleanup and return GStrv virStorageBackendISCSIDirectFindPoolSources: Rework cleanup

src/conf/storage_conf.c | 16 ++++ src/conf/storage_conf.h | 5 ++ src/libvirt_private.syms | 1 + src/storage/storage_backend_iscsi_direct.c | 87 +++++++++------------- 4 files changed, 56 insertions(+), 53 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano