Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains
On Mon, Sep 29, 2008 at 09:40:43AM -0700, Dan Smith wrote:
This patch adds code to the controller to set up a cgroup called
libvirt/lxc/$name, set the memory limit, and restrict devices. It also
adds bits to lxc_driver to properly clean up the cgroup on domain death.
If virCgroupHaveSupport() says that no support is available, then we just
allow the domain creation to proceed as it did before without resource
controls in place.
This is very nice & simple patch - my main comment is it would be
even simpler if the cgroup.h API exposed higher level semantically
targetted APIs, rather than general purposes setters/getters.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|