Re: [libvirt] [PATCH] vmx: Add support for video device VRAM size
On 12/30/2010 10:14 AM, Matthias Bolte wrote:
Update test suite accordingly.
+
+ virBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n",
+ def->vram * 1024); /* Scale from kilobytes to bytes */
Should this be %lld, def->vram * 1024ll, to avoid overflow concerns?
Otherwise, it looks okay to me. Conditional ACK based on the answer to
that question.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)