Re: [libvirt] [PATCHv4 3/5] S390: QEMU driver support for CCW addresses
On 03/14/2013 12:03 AM, Eric Blake wrote:
>> + if (virAsprintf(&addrstr, "%x.%x.%04x",
>
> Should we zero-pad the first two fields too, or is it common
> to only pad the last field in ccw addresses ?
but left this alone. You can submit a followup patch if it is necessary.
That's OK, only the last field is zero-padded.
I'll push this, along with the other ACK'd patches in the series, shortly.
Thanks for the review, cleanup and pushing.
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294