Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

On Fri, Mar 21, 2025 at 11:35:36 +0000, Daniel P. Berrangé wrote: > On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote: > > On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote: > > > On a Thursday in 2025, Peter Krempa via Devel wrote: > > > > From: Peter Krempa <pkrempa(a)redhat.com&gt; > > > > > > > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > > > > --- > > > > NEWS.rst | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/NEWS.rst b/NEWS.rst > > > > index 98ca838642..b2f3415001 100644 > > > > --- a/NEWS.rst > > > > +++ b/NEWS.rst > > > > @@ -37,6 +37,16 @@ v11.2.0 (unreleased) > > > > > > > > * **Improvements** > > > > > > > > + * qemu: Improved guest agent corner case error reporting > > > > + > > > > + The APIs using the guest agent now report two specific error codes aimed at > > > > + helping management applications and also users to differentiate between > > > > + the guest agent timing out while libvirt is attempting synchronisation, thus > > > > + no harm would be done and while being issued a command. > > > > + > > > > > > guest-agent considered harmful? :) > > > > Well, it can be sub-optimal to the VM if the filesystems are frozen > > while the management layer thinks they are not. > > In that scenario, the guest agent will unconditionally fail all commands > that are not safe for use while frozen. The guest agent indeed will fail. But also many things in the VM will be unhappy without the abiility to write. In one of the scenarios I was dealing with the guest agent took a bit longer to reply after getting the command to freeze. The user got a generic failure from libvirt timing out but the command was actually executed by the GA. Thus if you "forget" or "don't notice" that you froze filesystems that might be harmful.