Re: [libvirt] Remove bashisms from libvirt-guests
On 12/18/2010 04:51 AM, Laurent Léonard wrote:
>>
>> - retval wait $virsh_pid && printf '\r%s%-12s\n'
"$label" $"done"
>> + retval wait $virsh_pid && printf '\r%s%-12s\n'
"$label" "`gettext
>> \"done\"`"
>
> Likewise: "$(gettext "done")"
>
> But thanks for taking this on; we're getting closer to a nice solution.
I followed:
http://www.gnu.org/software/hello/manual/gettext/Preparing-Shell-Scripts....
but totally agree with your comments.
The gettext manual assumes that you are trying to be portable to all
sorts of /bin/sh, including Solaris's horribly-dated version that lacks
lots of POSIX features, hence it uses `` instead of $(). But for a
Linux init script, we can safely assume a decent POSIX shell.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)