Re: [libvirt] Add USB controller support
Hi
On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau <cfergeau(a)redhat.com> wrote:
Here is the second version of the patch series implementing USB
controller
support in libvirt-gconfig. There's a bug fixed in
GVirConfigDomainAddressUsb creation (type="usb" was missing) as well as a
few small bug fixes/changes in the test program. I also added an additional
patch implementing a gvir_config_domain_setup_default_usb_controllers to
make adding usb controllers easier following Marc-André's suggestion.
Series look good. I would still keep the helper in 14/14. I don't
think it hurts, and it saves the people from making mistakes when
using USB2 controller... I don't personally think libvirt-glib should
only be a dumb binding, it could also provide higher level common
helpers or functionality such as this, and later manipulating the XML
in certain way could be useful, like switching from VNC <-> Spice in a
smart way etc... imho, this is not a policy as long as that
logic/knowledge is not imposed, but left as a choice.
ack for the 1-13 patches, let see if 14/14 still holds a chance :-)
--
Marc-André Lureau