Re: [libvirt] [PATCH v2] virsh: fix incorrect argument errors for long options
On 04/29/2013 10:48 PM, Eric Blake wrote:
On 04/29/2013 11:27 AM, Ján Tomko wrote:
> For long options, print:
> * the option as specified by the user if it's unknown
> * the cannoncial long option if its argument is not
s/cannonical/canonical/
...
> a number (and should be)
>
> And for missing arguments, print both the short and
> the long option name.
> (Doing only one of those would require either parsing
> argv ourselves or let getopt print the errors, since
> we can't tell long and short options apart by optopt
> or longindex)
>
> https://bugzilla.redhat.com/show_bug.cgi?id=949373
Listing some before-and-after in the commit message would be very
helpful. Here's what I tried:
...
ACK. Reasonable for 1.0.5
Thank you, I've fixed the typo, added examples of the changed errors
to the commit message and pushed it.
Jan