Re: [libvirt] [PATCH] snapshot: ABI stability must include memory sizing

On 13.09.2011 22:27, Eric Blake wrote: > Commit 973fcd8f introduced the ability for qemu to reject snapshot > reversion on an ABI incompatibility; but the very example that was > first proposed on-list[1] as a demonstration of an ABI incompatibility, > namely that of changing the max memory allocation, was not being > checked for, resulting in a cryptic failure when running with larger > max mem than what the snapshot was created with: > error: operation failed: Error -22 while loading VM state > > This commit merely protects the three variables within mem that are > referenced by qemu_command.c, rather than all 7 (the other 4 variables > affect cgroup handling, but have no visible effect to the qemu guest). > > [1] https://www.redhat.com/archives/libvir-list/2010-December/msg00331.html > > * src/conf/domain_conf.c (virDomainDefCheckABIStability): Add > memory sizing checks. > --- > > See also https://bugzilla.redhat.com/show_bug.cgi?id=735553#c5

ACK