Re: [libvirt] [PATCHv2] Ignore bridge template names with multiple printf conversions

>> Okay, I see your counterargument. Still, strstr() is pretty expensive >> compared to just: >> >> if (def->bridge && >> (p = strchr(def->bridge, '%')) == strrchr(def->bridge, '%') && >> p[1] == 'd') >> > > Coverity complains : > > Event returned_null: "strchr" returns null (checked 273 out of 288 times). strchr does not return NULL here because networkFindUnusedBridgeName is only called if either def->bridge is NULL or def->bridge contains "%d".