On 02/17/2016 10:17 AM, Cole Robinson wrote:
Seems like the natural fit, since we are already adding other XML
bits
in the PostParse routine.
Previously AddImplicitControllers was only called at the end of XML
parsing, meaning code that builds a DomainDef by hand had to manually
call it. Now those PostParse callers get it for free.
There's some test churn here; xen xm and sexpr test suite bits weren't
calling this before, but now they are, so you'll see new IDE controllers.
I don't think this will cause problems in practice, since the code already
needs to handle these implicit controllers like in the case when a user
defines their own XML.
---
cc: jfehlig(a)suse.com
Jim, does that reasoning for the xen churn sound good to you?
Yes, it sounds good to me.
Regards,
Jim