On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
This is only used in qemu_command.c, so move it, and clarify that it's really about identifying if the serial config is a platform device or not.
You're not only moving and renaming the function, you're also entirely reversing its logic. Please mention that as well in the commit message.
+ if ((def->os.arch == VIR_ARCH_ARMV7L) || + (def->os.arch == VIR_ARCH_AARCH64)) { + /* TARGET_TYPE_ISA here really means 'the default', which we + treat as whatever the built in platform serial device is on. + And for platform devices we can't use -chardev */
This comment definitely needs to be updated now that we're using -chardev for everything, and this is the perfect time. Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization