Re: [libvirt] [PATCH v2 09/12] qemuDomainDetachDeviceLiveAndConfig: Avoid overwriting @ret
On Thu, May 24, 2018 at 01:13:36PM +0200, Michal Privoznik wrote:
The fact that we are overwriting @ret multiple times is very
confusing to see what is actually happening here.
-EPARSE
s/is very confusing/makes it difficult to see/
Follow our
traditional pattern where @ret is initialized to -1, and set to 0
only in case we know we succeeded.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_driver.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)