Re: [PATCH 07/15] storage file: fill in src->dataFileStore during file probe
On Thu, Nov 21, 2024 at 15:11:46 +0100, Peter Krempa wrote:
On Wed, Nov 20, 2024 at 18:48:42 +0300, Nikolai Barybin via Devel
wrote:
> Signed-off-by: Nikolai Barybin <nikolai.barybin(a)virtuozzo.com>
> ---
> src/storage_file/storage_source.c | 39 +++++++++++++++++++++++++++++++
> src/storage_file/storage_source.h | 4 ++++
> 2 files changed, 43 insertions(+)
@@ -1391,6 +1424,11 @@
virStorageSourceGetMetadataRecurse(virStorageSource *src,
}
}
+ if (src->dataFileRaw) {
In addition to this change we must also not fill this if the current
'src' already has the 'dataFileStore' member populated. It can happen
that you have the last image in chain with a <dataStore> but without
<backingStore> that situation invokes probing of the image and here we'd
overwrite the user-configured <dataStore>.