Re: [libvirt] [PATCH] tests: Remove caps from DO_TEST_PARSE_ERROR() calls
On Wed, 2018-01-31 at 09:38 +0100, Peter Krempa wrote:
> @@ -1037,17 +1034,10 @@ mymain(void)
> QEMU_CAPS_DRIVE_DISCARD,
> QEMU_CAPS_DRIVE_DETECT_ZEROES);
> DO_TEST("disk-snapshot", NONE);
> - DO_TEST_PARSE_ERROR("disk-same-targets",
> - QEMU_CAPS_SCSI_LSI,
> - QEMU_CAPS_DEVICE_USB_STORAGE, QEMU_CAPS_NODEFCONFIG);
So this is not quite equivalent. Here's a diff of error messages prior
and after your patch:
$ diff -u stderr stderr2
--- stderr 2018-01-31 09:34:37.295273384 +0100
+++ stderr2 2018-01-31 09:34:39.241273208 +0100
[...]
@@ -896,7 +895,7 @@
OK
560) QEMU XML-2-ARGV s390-panic-missing ... OK
561) QEMU XML-2-ARGV s390-no-parallel ... Got expected
error:
- error : qemuDomainChrDefValidate:3588 : unsupported configuration: parallel ports are
not supported
+ error : virDomainPCIAddressGetNextAddr:805 : XML error: No PCI buses available
OK
562) QEMU XML-2-ARGV s390-serial ... OK
563) QEMU XML-2-ARGV s390-serial-2 ... OK
Yeah, I thought about going through this exercise of comparing the
output from before and after my patch - but only after leaving the
office for the day ;)
I could go through the list and only remove the capabilities that
are really unused, but it sounds like an awful lot of work just to
shave less than 100 lines off the test suite. Let's just drop it.
--
Andrea Bolognani / Red Hat / Virtualization