Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: > > > On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: >> Empty name is not allowed by schema but qemu is able to start with such >> a config (and I guess some other hypervisors too). As a result name will >> be generated by kernel and have form 'tap<N>'. At the same time if >> target element is ommited in config the name will be generated by >> libvirt and have form 'vnet<N>'. Let's have only the latter pattern >> for autogenerated names by treating empty name as ommited. >> >> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt; >> --- > > Reviewed-by: Daniel Henrique Barboza <danielhb413(a)gmail.com&gt; Change like this usually requires a test XML addition so that we can validate and prevent regressions.