Re: [libvirt] [jenkins-ci PATCH 01/17] guests: Deal with multilib path
On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
+# Add the multilib path to the LD_LIBRARY_PATH, PKG_CONFIG_PATH, and
GI_TYPELIB_PATH
+# The multilib path can be discovered either using `dpkg-architecture` (on Debian based
+# machines) or by calling `rpm --eval '%{_lib}'` (on rpm based machines).
This comment is a bit verbose and basically describes the code below
step by step which is unnecessary, so I've rewritten it to read
These search paths need to encode the OS architecture in some way
in order to work, so use the appropriate tool to obtain this
information and adjust them accordingly
and pushed the patch with my
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
I'll review the rest of the series as time permits.
--
Andrea Bolognani / Red Hat / Virtualization