Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

On 11/26/2013 08:23 AM, Amos Kong wrote: You forced me to check the code :) We're safe. Libvirt lets the user control both rate and period in the XML. If the user specifies neither, then libvirt doesn't pass max-bytes or period (but that's the default for unlimited, and you argued that even with your changes, the default is still effectively unlimited); the same is true if the user specifies period but not rate (a different period with no maximum is still effectively unlimited throughput, so it didn't really matter that we don't pass period on through). It is only when the user specifies rate that libvirt passes anything on to qemu; and in that case, libvirt always passes both max-bytes and period (either with a period set by user, or with the period forced to 1000). Agreed. Phew. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org