Re: [libvirt] [PATCH] qemu: The ppc64 target can run both ppc64 and ppc64le guests
On Tue, 2015-09-15 at 13:48 +0100, Daniel P. Berrange wrote:
The virQEMUCapsFindBinaryForArch metho already has a bunch of logic
to
deal with fact that one binary can support multiple different
architectures. For example, x86_64 can support i686. It looks like we
hit the same problem as ppc64/ppc64le in that case and you have not
handled it here. It would be desirable to avoid having to have the
same
compat logic in two places too.
I've just sent out a v2[1] which takes the logic you're referring
to out of virQEMUCapsFindBinaryForArch() and into a separate
function which is then reused when looking up capabilities.
Of course it's a slightly larger patch this time around :)
Cheers.
[1] https://www.redhat.com/archives/libvir-list/2015-September/msg00475
.html
--
Andrea Bolognani
Software Engineer - Virtualization Team