Re: [libvirt] [PATCH v3 25/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/util/*

On 05/20/2013 06:12 AM, Michal Privoznik wrote: While the 0/1 distinction makes sense for VIR_STRDUP (as you can argue that knowing whether the caller passed NULL is sometimes useful), most other larger functions that happen to end on a VIR_STRDUP aren't really using the 0/1 as a differentiation on whether the user passed in NULL, but are always dup'ing a non-NULL string. But returning 1 when it conveys no real information seems awkward. Therefore, I think I'd rather see you rewrite code to continue to return explicit 0 on functions that were previously returning 0, instead of optimizing by passing the VIR_STRDUP return value straight through. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org