Re: [PATCH 7/8] hyperv: implement connectGetVersion
On Saturday, 3 October 2020 01:02:47 CEST Matt Coleman wrote:
On Oct 2, 2020, at 2:48 AM, Pino Toscano <ptoscano(a)redhat.com>
wrote:
> IMHO these explanations should be documented in the Hyper-V driver
> page: docs/drvhyperv.html.in. This way, users know about the different
> value returned by virConnectGetVersion() by the Hyper-V driver, and
> can unmangle it to get the real Hyper-V version.
You’re absolutely right. I’ll add some documentation about this. Would
you prefer it as a separate commit or included with the code changes?
IMHO it makes sense in the same commit, as it would be the new logic
and the documentation for it (in both code comments and rST for users)
added at the same time.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)