Re: [libvirt] [PATCH v2] add network disk support

This patch adds network disk support to libvirt/QEMU. The currently supported protocols are nbd, rbd, and sheepdog. The XML syntax is like this: <disk type="network" device="disk"> <driver name="qemu" type="raw" /> <source protocol='rbd|sheepdog|nbd' name="...some image identifier..."> <host name="mon1.example.org" port="6000"> <host name="mon2.example.org" port="6000"> <host name="mon3.example.org" port="6000"> </source> <target dev="vda" bus="virtio" /> </disk> Signed-off-by: MORITA Kazutaka <morita.kazutaka(a)lab.ntt.co.jp&gt; --- Hi, Thanks for your comments, Daniel. Here is a fixed version. Changes from v1 to v2 are: - check whether the XML input is valid or not more strictly - fix memory leak in the error path - add NULL check of the return value of strdup() Thanks, Kazutaka docs/schemas/domain.rng | 31 +++++++ src/conf/domain_conf.c | 95 +++++++++++++++++++- src/conf/domain_conf.h | 20 ++++ src/qemu/qemu_conf.c | 221 ++++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 358 insertions(+), 9 deletions(-)