Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket

12 May 2016


      On Wed, May 11, 2016 at 08:13:53PM +0200, Marc-André Lureau wrote:
...
Hi
On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina <phrdina@redhat.com> wrote:
...
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
[...]
...
...
@@ -7636,11 +7659,17 @@ qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg,
         !cfg->spicePassword)
         virBufferAddLit(&opt, "disable-ticketing,");
-    if (glisten->tlsPort > 0)
+    if (useTLS)
         virBufferAsprintf(&opt, "x509-dir=%s,", cfg->spiceTLSx509certdir);
switch (defaultMode) {
     case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_SECURE:
+        if (!useTLS) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("spice defaultMode secure requested in XML "
+                             "configuration, but TLS is not available"));
+            goto error;
+        }
I am not quite sure about the simpification you have made to
defaultMode checks. Why not put it in a previous seperate patch to
make this more clear?
I was just lazy to create a separate patch, but I can do that.

Pavel

    