Re: [Libvir] [PATCH 1/2] virDomainMigrate implementation (Xen only, no remote, no qemu, no virsh)

Dan Smith wrote: >RJ> * Params is a linked list of hypervisor-specific parameters. Each >RJ> * element is a virMigrateParamPtr containing the following fields: >RJ> * name Parameter name being set. >RJ> * value A union expressing the value. >RJ> * value.strv A string value. >RJ> * value.longv A long value. >RJ> * next Next in linked list (or NULL for end of list). > >This should allow us to pass URIs to qemu, as well. I like it :) Can you give us some idea of how QEMU migration works? KVM added a "migrate" function to the qemu console ("migrate <URI>"). For example: "migrate tcp://hostname:4444" and "migrate ssh://hostname". I'm not sure if that is in qemu upstream, or whether qemu upstream is doing something else. I think that we shouldn't pass URIs, but instead we should construct the URI from the hostname and port number, and something like an optional "VIR_KVM_TRANSPORT" virMigrateParamPtr. (This implies that port number, like hostname, becomes a main argument to virDomainMigrate). Incidentally, KVM also supports cancelling migrations (this interface doesn't), getting the status of migrations (this interface assumes the migration is synchronous and is supposed to only return when the migration is done), and setting resource limits. The latter implies that resource limits should be a non-Xen-specific parameter.