Re: [libvirt] PATCH: 3/4: Introduce libvirt_lxc binary
On Wed, Aug 13, 2008 at 10:20:03AM -0700, Dan Smith wrote:
DB> This patch is the important one, switching from an I/O
controller
DB> which is simply fork'd off libvirtd, to a properly execable
DB> libvirt_lxc binary.
This works for me. The network interfaces aren't cleaned up properly on
destroy, and I get an error from the kernel about a reference count on
the fake 'lo' interface for the container. However, I get that some of
the time in the original code as well, so I don't see any reason holding
this stuff up any further, and I will see about tracking that down.
The deletion of veth's is the last thing the controller process does.
So assuming it doesn't crash they should be cleaned up. It is probably
worth making the libvirtd LXC driver do cleanup of veths too, as a
safety net.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|