Re: [libvirt] [PATCH 6/8] Add client side support for FD passing

On 10/21/2011 06:55 AM, Daniel P. Berrange wrote: >@@ -697,6 +708,15 @@ virNetClientCallDispatch(virNetClientPtr client) > case VIR_NET_REPLY: /* Normal RPC replies */ > return virNetClientCallDispatchReply(client); > >+ case VIR_NET_REPLY_WITH_FDS: /* Normal RPC replies with FDs */ >+ if (virNetMessageDecodeNumFDs(&client->msg)< 0) >+ return -1; >+ for (i = 0 ; i< client->msg.nfds ; i++) { >+ if ((client->msg.fds[i] = virNetSocketRecvFD(client->sock))< 0) You do realize that gnulib's sendfd/recvfd pass a single byte alongside each out-of-band fd (since passing fds with 0-byte messages isn't portable). It looks like you were careful to ensure that fds are only sent and received in between complete messages; so hopefully we don't ever run into any problems where the extra byte payloads gets interleaved with real rpc traffic, since that could cause confusion on the current state of bytes going between endpoints. Is encryption ever used on UNIX sockets, or is that only for TCP connections?