Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk
On Mon, Jun 22, 2020 at 02:59:10PM +0200, Thomas Huth wrote:
On 22/06/2020 13.29, Gerd Hoffmann wrote:
> Add deprecation message to the audio init function.
>
> Factor out audio initialization and call that from
> both audio init and realize, so setting audiodev via
> -global is enough to properly initialize pcspk.
>
> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
> ---
> hw/audio/pcspk.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
[...]
> +static int pcspk_audio_init_soundhw(ISABus *bus)
> +{
> + PCSpkState *s = pcspk_state;
> +
> + warn_report("'-soundhw pcspk' is deprecated, "
> + "please set a backend using '-global
isa-pcspk.audiodev=<name>' instead");
> + return pcspk_audio_init(s);
> +}
While "-soundhw pcspk" is quite easy to use for the average user, I
think the "-global" options will be quite hard to figure out, especially
once this deprecation message got removed again when -soundhw has been
deleted.
See also patch 19/19.
Could you maybe add a description how to configure the
pc-speaker to docs/system/target-i386-desc.rst.inc, too?
Makes sense indeed.
take care,
Gerd