Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version
On Tue, 2016-02-16 at 10:15 +0000, Daniel P. Berrange wrote:
> Back to GIV. Recognized values of gic-version are fixed at
compile
> time: 2, 3, host. Once again, QOM does things in code rather than data:
> the set of values is defined in the setter function
> virt_set_gic_version().
>
> Some values are accepted only together with other configuration: 3
> requires accel=kvm (for now), host requires -cpu host. Static
> introspection can't show such constraints.
>
> Would the proposed query-gic-capability show them? How?
Also bear in mind that libvirt probes capabilities using '-m none' so
you're not going to have any 'virt' machine type instantiated when
probing is done.
The idea is to add this information to domain capabilities, which
already have virtualization type, architecture and machine type as
inputs.
Since GIC is only available for the virt machine type on ARM hosts,
and the GIC versions might be limited by using TCG instead of KVM,
it seems like it would fit nicely...
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team