since v1:
- .bash_logout is removed from the user home environment (causes builds to fail
on Debian)
- gitlab-runner is now downloaded to and executed from user's bin/ directory
instead of using /usr/local/bin
- both RC and systemd service files now define the user explicitly that the init
system changes to when spawning the gitlab-runner service
- the gitlab flavour tasks file now relies on shell's 'creates' module
argument
so that the agent registration is idempotent rather than touching the
dirs/files explicitly
- both gitlab URL and runner token are now files editable under
~/.config/lcitool
since v2:
- download location changed to /usr/local/bin
- config location changed to /etc/gitlab-runner (readable to the gitlab user)
- machine tagging changed to 'os_version-distro_major_number'
- fixed the regression caused by the gitlab code which was checking the gitlab
config files unconditionally for all flavours
- cosmetic syntactic changes to the Python code as requested by the reviewer
Both the config.toml improvement in terms of replacing the ~/.config/lcitool
files as discussed during the v1 review process as well as cloudinit usage is
planned for a separate respective series, so for now, we'll have to live with 2
new config files and cloud images will need to be built manually.
Erik Skultety (5):
guests: users: Discard the .bash_logout skeleton file
guests: templates: Introduce a gitlab-runner systemd service template
guests: templates: Introduce a gitlab-runner RC init service template
guests: Introduce the new 'gitlab' flavor
guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script
guests/lcitool | 46 ++++++++++++++-
guests/playbooks/update/main.yml | 5 ++
guests/playbooks/update/tasks/gitlab.yml | 58 +++++++++++++++++++
guests/playbooks/update/tasks/users.yml | 3 +-
.../update/templates/gitlab-runner.j2 | 31 ++++++++++
.../update/templates/gitlab-runner.service.j2 | 14 +++++
6 files changed, 154 insertions(+), 3 deletions(-)
create mode 100644 guests/playbooks/update/tasks/gitlab.yml
create mode 100644 guests/playbooks/update/templates/gitlab-runner.j2
create mode 100644 guests/playbooks/update/templates/gitlab-runner.service.j2
--
2.25.1