Re: [libvirt] [libvirt-glib] [PATCH 0/4] Add more snapshot API
On Sat, Aug 02, 2014 at 10:41:45AM +0200, mail(a)baedert.org wrote:
From: Timm Bäder <mail(a)baedert.org>
The implementation of gvir_domain_snapshot_set_config does not allow
renaming of the snapshot as that will just create a new snapshot in
any case (should that by documented?). But it looks like the same
is true for gvir_domain_set_config?
gvir_domain_set_config is a bit different to the snapshot stuff as it
uses virDomainDefineXML rather than virDomainCreateXML. I'd expect that
as long as the domain UUID is not modified, this will modify an existing
domain.
Regarding the use of virDomainSnapshotCreateXML, isn't this going to do
the right thing as you specified the
VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE? (I'm a bit confused by the API doc
;)
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 819 bytes)