Re: [libvirt] [PATCH 2/2] qemu: Add libvirt version check to refresh capabilities algorithm
On Sat, May 23, 2015 at 10:33:31AM -0400, John Ferlan wrote:
Rather than an algorithm based solely on libvirtd ctime to refresh
the
capabilities add the element of the libvirt build version into the equation.
Since that version wouldn't be there prior to this code being run - don't
fail on reading the capabilities if not found. In this case, the cache
will always be read when a new libvirt version is installed.
If you upgrade to new libvirt, the file change time should cause us
to invalidate the cache regardless - this version check is jsut a
failsafe, so agree that ignoring missing version is fine. Conversely
though, reporting error on missing version is fine too, as that'll
force us to rebuild the cache.
ACK either way.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|