Re: [PATCH] build: Bump minimul glib2 version to 2.66.0
On Mon, Jan 27, 2025 at 20:16:40 +0100, Pavel Hrdina wrote:
On Mon, Jan 27, 2025 at 06:12:10PM +0100, Peter Krempa wrote:
> Per our supported platforms the minimum available versions are:
>
> CentOS Stream 9: 2.68.4
> Debian 11: 2.66.8
> Fedora 39: 2.78.6
> openSUSE Leap 15.6: 2.78.6
> Ubuntu 24.04: 2.72.4
> FreeBSD: 2.80.5
Apart from fixing the typo in the summary I've also noticed that I wrote
Ubuntu 24.04, but the version is for Ubuntu 22.04. I'll update the table
and also add macOS versions:
CentOS Stream 9: 2.68.4
Debian 11: 2.66.8
Fedora 39: 2.78.6
openSUSE Leap 15.6: 2.78.6
Ubuntu 22.04: 2.72.4
FreeBSD ports: 2.80.5
macOS homebrew: 2.82.4
macOS macports: 2.78.4
I've also double checked against repology that I didn't make another
mistake.
> Bump to 2.66 which is limited by Debian 11. While ideally
we'd bump to
> 2.68 which would give us 'g_strv_builder' and friends 2.66 is enough for
> g_ptr_array_steal() which can be used to emulate the former with almost
> no extra code.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> libvirt.spec.in | 2 +-
> meson.build | 2 +-
> src/libvirt_private.syms | 4 --
> src/qemu/qemu_agent.c | 2 +-
> src/qemu/qemu_monitor.c | 2 +-
> src/util/glibcompat.c | 94 ----------------------------------------
> src/util/glibcompat.h | 18 --------
> src/util/vireventglib.c | 12 ++---
> 8 files changed, 10 insertions(+), 126 deletions(-)
s/minimul/minimum/ in subject
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
Thanks. I'll push this after CI passes.