On 02/20/13 18:44, Laine Stump wrote:
On 02/20/2013 12:06 PM, Peter Krempa wrote:
Get rid of the "identical" variable in the ABI stability checks in favor of return statements and break or refactor very long lines where possible. --- src/conf/domain_conf.c | 469 +++++++++++++++++++++---------------------------- 1 file changed, 200 insertions(+), 269 deletions(-)
ACK (although in general I have some misgivings about cosmetic changes like this, as they obscure the history of the modified lines, making it more tedious to sift through the past commit logs to understand why certain bits of code exist / what changed, etc).
Thankfully there's a script for vim (called fugitive) and for sure for other editors too that allows to browse the blame history. Thanks for the reviews, I pushed patches 1-6 and 8. Peter