Re: [Libvir] unchecked `malloc' calls

On Thu, Mar 30, 2006 at 12:26:31PM +0200, Jim Meyering wrote: > Hello, > > In browsing through the code, I noticed that there are many > places in which the code doesn't check for malloc returning NULL. > E.g., > > ./virsh.c: ids = malloc(sizeof(int) * maxid); > ./virsh.c- virConnectListDomains(ctl->conn, &ids[0], maxid); Actually virConnectListDomains which is in the library will check the pointer. It won't crash in the library ! > ./virsh.c: *res = malloc(sz + 1); > ./virsh.c- memcpy(*res, tkstr, sz); > > ./virsh.c: res = malloc(strlen(name) + 3); > ./virsh.c- sprintf(res, "--%s", name); virsh.c is code for the command line tool, I would say it's less critical there than in the library if malloc fails and it leads to a crash. But I'm sure Karel and me will enjoy a patch to fix this.