Re: [libvirt] [PATCH v3 1/2] Optimize machine option to set more options with it

>> } else { >> + virBuffer buf = VIR_BUFFER_INITIALIZER; >> >> virCommandAddArg(cmd, "-machine"); >> - virBufferAsprintf(&buf, "%s", def->os.machine); >> + virBufferAdd(&buf, def->os.machine, -1); >> >> if (def->mem.dump_core) { >> if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE)) { >> - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, >> - "%s", _("dump-guest-core is not >> available " >> - " with this QEMU binary")); >> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", >> + _("dump-guest-core is not available " >> + "with this QEMU binary")); >> return -1;

Just ran a make -C tests valgrind and got the following which points right at this patch: