Re: [libvirt] [PATCH 1/3] block rebase: add new API virDomainBlockRebase

On 02/01/2012 12:05 AM, Eric Blake wrote: > Qemu is adding the ability to do a partial rebase. That is, given: > > base<- intermediate<- current > > virDomainBlockPull will produce: > > current > > but qemu now has the ability to leave base in the chain, to produce: > > base<- current >

> +int virDomainBlockRebase(virDomainPtr dom, const char *disk, > + const char *base, unsigned long bandwidth, > + unsigned int flags) > +{ > + virConnectPtr conn; > + > + VIR_DOMAIN_DEBUG(dom, "disk=%p, base=%s bandwidth=%lu, flags=%x", disk is just a character string, isn't it? If so, why not use %s instead of %p?

Otherwise, this is all pretty straightforward. ACK.