On Wed, Apr 17, 2019 at 09:09:13 -0500, Eric Blake wrote:
Introduce a few more new virsh commands for performing backup jobs, as well as creating a checkpoint atomically with a snapshot.
At this time, I did not opt for a convenience command 'backup-begin-as' that cobbles together appropriate XML from the user's command line arguments, but that may be a viable future extension. Similarly, since backup is a potentially long-running operation, it might be nice to add some sugar that automatically handles waiting for the job to end, rather than making the user have to poll or figure out virsh event to do the same.
Signed-off-by: Eric Blake <eblake@redhat.com> --- tools/virsh-domain.c | 245 +++++++++++++++++++++++++++++++++++++++++ tools/virsh-snapshot.c | 37 ++++++- tools/virsh.pod | 64 ++++++++++- 3 files changed, 336 insertions(+), 10 deletions(-)
This again looks unfinished due to containing commented out code. The change to the snapshot code don't seem relevant and should be separated into a new commit as this commit adds primarily backup APIs and adding the checkpoint option is not relevant. Also all the snapshot code in virsh is in a separate file, but the backup/checkpoint code is put together with the reset.