Re: [libvirt] [PATCH] snapshot: improve qemu handling of reused snapshot targets

I would agree. It makes more sense if REUSE reuses the whole file including its content instead of reusing just the file name and some metadata. > Note that this flag is all-or-nothing, and only selects between > 'existing' and the default 'absolute-paths'. A more flexible > approach that would allow per-disk selections, as well as adding > support for the 'no-backing-file' mode, would be possible by > extending the <domainsnapshot> xml to have a per-disk mode, but > until we have a management application expressing a need for that > additional complexity, it is not worth doing. Every opportunity to not increase the complexity of snapshot API even moreis always welcome :-) The patch looks like it's doing what you say it's doing, so ACK (with the additional patch you plan to squash in).