On 03/23/2012 11:06 AM, Jiri Denemark wrote:
I would agree. It makes more sense if REUSE reuses the whole file including its content instead of reusing just the file name and some metadata.
Note that this flag is all-or-nothing, and only selects between 'existing' and the default 'absolute-paths'. A more flexible approach that would allow per-disk selections, as well as adding support for the 'no-backing-file' mode, would be possible by extending the <domainsnapshot> xml to have a per-disk mode, but until we have a management application expressing a need for that additional complexity, it is not worth doing.
Every opportunity to not increase the complexity of snapshot API even moreis always welcome :-)
The patch looks like it's doing what you say it's doing, so ACK (with the additional patch you plan to squash in).
Thanks; I've pushed round 3 now. Round 4 (XML <mirror>) and 5 (snapshot delete bits) are tabled, perhaps permanently, while I instead work on virDomainBlockRebase for live block migration with pull. I still plan on hammering these more over the next week, but any future fixes will be followup patches. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org