Re: [libvirt] [PATCH v2 2/3] conf: Reintroduce action to virDomainDefCompatibleDevice
On 06/26/2018 04:30 PM, John Ferlan wrote:
On 06/26/2018 06:21 AM, Michal Privoznik wrote:
> This was lost in c57f3fd2f8999d17e01. But now we are going to
> need it again.
Looks like that commit also "lost" the compatible device check on detach
too (e.g. ACTION_DETACH) without explanation. Whether at the time it
then became the last consumer of virDomainDeviceAction is another question.
There's no need to check for device compatibility on device detach, is
there? The virDomainDefCompatibleDevice() merely checks whether new
device that we are trying to hot-plug or change would not break
assumptions made by other parts of domain config. These can't be broken
if we're removing a device.
So, since you're bringing this back to life - should those checks be
reinstated into the Detach code (lxc, qemu)? If not, surely
ACTION_DETACH then still isn't used.
Yes, it is unused. I can remove it, although for completion sake I
rather have it in.
Can I assume you tested bz1439991 with the new condition?
Yes you can. I've tested this.
Michal