Re: [libvirt] [PATCH] tests: Don't use bash if we don't have to

On 07/29/2011 06:19 AM, Matthias Bolte wrote: > > This tested failed on FreeBSD because it was using bash, that might > not be installed. > --- >  tests/int-overflow |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/int-overflow b/tests/int-overflow > index baf2eef..36e5536 100755 > --- a/tests/int-overflow > +++ b/tests/int-overflow > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/bin/sh This script sources test-lib.sh, which in turn uses features like $() that are not portable to Solaris /bin/sh.  But I didn't see any bash-isms - everything in those two files appears to be safe for use with POSIX sh, so I'm okay with the patch as is: ACK.